Let transformers know when a model is being traced via jax.jit (torchax) #42611
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qihqi
force-pushed
the
qihqi-support-jax-jit
branch
from
9aa3291 to
a041420
Compare
Cyrilvallez
approved these changes
Dec 4, 2025
Member
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
LGTM! Would just like to add it to the docstring as well if you don't mind! 🤗
Rocketknight1
force-pushed
the
qihqi-support-jax-jit
branch
from
a041420 to
266adfa
Compare
Rocketknight1
approved these changes
Dec 4, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Yep, change looks good and after some internal discussion we're happy to approve!
tengomucho
approved these changes
Dec 4, 2025
Contributor
tengomucho
left a comment
tengomucho
left a comment
There was a problem hiding this comment.
Thanks for the contribution @qihqi !
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
CI issues are unrelated and seem to be transient connection timeouts - @cyril do you want to force merge, or will we just wait and rebase? |
qihqi
force-pushed
the
qihqi-support-jax-jit
branch
from
4e56c0b to
544c760
Compare
Contributor
Author
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
transformers current recognizes when the PyTorch model is
being traced instead of executed, so it knows to not use untraceable ops (data-dependent ops).
However, currently it recognizes torchscript, fx trace, dynamo but does not recognize
jax.jitvia torchax.This PR adds detecting jax.jit.
Fixes google/torchax#56
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@vasqu @ArthurZucker @Cyrilvallez