Skip to content

maxNestingDepth 10000 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trobro merged 2 commits into from
Apr 20, 2025
Merged

maxNestingDepth 10000 #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f114143
maxNestingDepth 10000
trobro Apr 16, 2025
b3e51b1
indentation
trobro Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/HJSON/HJSONParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ class HJSONParser
private $ch; // The current character
private $escapee = [];
private $keepWsc; // keep whitespace
private $maxNestingDepth = 10000;
private $nestingDepth;

public function __construct()
{
Expand Down Expand Up @@ -44,6 +46,7 @@ public function parse($source, $options = [])

private function resetAt()
{
$this->nestingDepth = 0;
$this->at = 0;
$this->ch = ' ';
}
Expand Down Expand Up @@ -99,9 +102,15 @@ private function value()
$this->white();
switch ($this->ch) {
case '{':
return $this->object();
$this->nestingDepth++;
$ret = $this->object();
$this->nestingDepth--;
return $ret;
case '[':
return $this->_array();
$this->nestingDepth++;
$ret = $this->_array();
$this->nestingDepth--;
return $ret;
case '"':
return $this->string('"');
case '\'':
Expand Down Expand Up @@ -157,6 +166,10 @@ private function _array()
// Parse an array value.
// assumeing ch === '['

if ($this->nestingDepth > $this->maxNestingDepth) {
$this->error("Exceeded max depth (".$this->maxNestingDepth.")");
}

$array = [];
$kw = null;
$wat = null;
Expand Down Expand Up @@ -210,6 +223,11 @@ private function _array()
private function object($withoutBraces = false)
{
// Parse an object value.

if ($this->nestingDepth > $this->maxNestingDepth) {
$this->error("Exceeded max depth (".$this->maxNestingDepth.")");
}

$key = null;
$object = new \stdClass();
$kw = null;
Expand Down