-
-
Notifications
You must be signed in to change notification settings - Fork 34
Fix parent culture fallback in JsonResourceManager #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: hishamco <3237266+hishamco@users.noreply.github.com>
|
@copilot can you add unit tests to make sure nothing is broken |
Co-authored-by: hishamco <3237266+hishamco@users.noreply.github.com>
Added unit tests in commit 4efe03c:
All 40 unit tests and 5 functional tests pass. |
| [Fact] | ||
| public async void CultureBasedResourcesUsesIStringLocalizer() | ||
| { | ||
| var webHostBuilder = new WebHostBuilder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot replace the deprecated WebhostBuilder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced deprecated WebHostBuilder with modern WebApplication.CreateBuilder() pattern in commit f6e4d48. Also changed method signature from async void to async Task and updated to use minimal API pattern with app.MapGet().
Co-authored-by: hishamco <3237266+hishamco@users.noreply.github.com>
Latest Changes
Replaced the deprecated
WebHostBuilderwith the modernWebApplication.CreateBuilder()pattern in theCultureBasedResourcesUsesIStringLocalizertest:WebHostBuilderwithWebApplication.CreateBuilder()app.MapGet()async voidtoasync Task(fixing xUnit warning)Microsoft.AspNetCore.Hosting, addedMicrosoft.Extensions.Hostingapp.GetTestClient()instead of creating aTestServerdirectlyStopAsync()call (handled byawait using)All 52 unit tests and 5 functional tests pass.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.