adds expand nodes (macros) #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Cool! This makes sense. Just going to wait for travis to be back online to merge, if that's OK |
Collaborator
Author
|
Not ready yet. I will ping you. |
Owner
|
Ok, retitled since I assumed it was. Thanks for contributing! |
bernt-matthias
force-pushed
the
topic/macros
branch
from
421fc51 to
208c4cc
Compare
Collaborator
Author
|
I guess this is nearly done. I would suggest that I extent the tests in hexylena/argparse2tool#65 such that you see it in action. |
bernt-matthias
added a commit
to bernt-matthias/argparse2tool
that referenced
this pull request
Apr 30, 2020
corresponding to hexylena/galaxyxml#18
bernt-matthias
added a commit
to bernt-matthias/argparse2tool
that referenced
this pull request
Jul 29, 2020
corresponding to hexylena/galaxyxml#18
bernt-matthias
added a commit
to bernt-matthias/argparse2tool
that referenced
this pull request
Jul 29, 2020
corresponding to hexylena/galaxyxml#18
bernt-matthias
added a commit
to bernt-matthias/argparse2tool
that referenced
this pull request
Jul 29, 2020
corresponding to hexylena/galaxyxml#18
bernt-matthias
force-pushed
the
topic/macros
branch
from
da95667 to
c18842b
Compare
bernt-matthias
commented
Jan 24, 2021
bernt-matthias
commented
Jan 24, 2021
Collaborator
Author
|
TODOs:
|
bernt-matthias
force-pushed
the
topic/macros
branch
from
b7a1188 to
ac47737
Compare
bernt-matthias
changed the title
bernt-matthias
force-pushed
the
topic/macros
branch
from
ac47737 to
718182e
Compare
Expand can be used everywhere and adds <expand macro="..."> ExpandIO adds an additional token with the same name as the macro but in upper case to the commands section. Can only be used as child of inputs and outputs
each subparser that is a parent of another is becomes a two macros (in/out) and a token (commandline). implemented in MacrosTool
if attribute is absent introduce <expand ...> with predefined name
- correct identifiers - create cli for children
- plus docs - also return at least some TODO in the CLI generated for output collections
bernt-matthias
force-pushed
the
topic/macros
branch
from
81d25f2 to
a204e06
Compare
if there is a when (which has a None identifier) on the path to the root then the export failed. also fix linter errors
bernt-matthias
force-pushed
the
topic/macros
branch
from
207e88d to
cb5739a
Compare
hexylena
reviewed
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand can be used everywhere and adds
ExpandIO adds an additional token with the same name as the macro
but in upper case to the commands section. Can only be used as
child of inputs and outputs