Merge pull request #5 from hexawulf/fix/duplicate-close-button #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Remove duplicate close button in AboutModal
…but your version should work fine.
This commit introduces the CodePatchwork logo as the website's favicon.
The following changes were made:
- Extracted the SVG logo from the `CodePatchworkLogo` React component.
- Prepared and cleaned the SVG for use as a favicon.
- Generated `favicon.svg` directly from the cleaned SVG.
- Generated PNG favicons in various sizes:
- `favicon-16x16.png`
- `favicon-32x32.png`
- `apple-touch-icon.png` (180x180)
- Created `favicon.ico` from the 16x16 and 32x32 PNGs.
- All favicon files have been added to the `public/` directory.
- Updated `client/index.html` to include the necessary `<link>` tags for all new favicons, ensuring they are referenced correctly.
This replaces the generic browser default favicon with the branded CodePatchwork logo, enhancing brand consistency.
feat: Add custom CodePatchwork logo as favicon
This commit addresses an issue where favicons were not displaying correctly. The root cause was identified as the use of `className` (a React-specific attribute) instead of `class` within the `public/favicon.svg` file. Changes: - Modified `public/favicon.svg` to replace all `className=` attributes with `class=`. - Re-generated all PNG favicons (`favicon-16x16.png`, `favicon-32x32.png`, `apple-touch-icon.png`) from the corrected `public/favicon.svg` to ensure they reflect the valid SVG structure. - Re-created `public/favicon.ico` using the updated PNGs. The links in `client/index.html` were already correct and did not require changes. This change should allow browsers to correctly render the SVG favicon and, by extension, ensure the derived PNGs/ICO are accurate.
fix: Correct SVG class attributes and regenerate favicons
The favicon was not displaying because Vite's `root` was set to `client/`, causing it to look for the `public/` directory within `client/` by default. This commit updates `vite.config.ts` to explicitly set `publicDir` to point to the `public/` directory at the project root. This ensures that Vite can find and serve the favicon files and other static assets correctly.
Fix: Configure Vite to correctly serve favicons
This commit significantly revamps the README.md to improve engagement and prominently feature the live demo. Key changes include: - Added a prominent "Try CodePatchwork Live!" section with a large call-to-action button and badge linking to https://www.codepatchwork.com. - Enhanced the header with project badges (Stars, License, Demo), a new tagline, and a more descriptive introduction. - Incorporated a Table of Contents for easier navigation. - Added a "Quick Start" section directing users to the live demo or minimal local setup. - Reorganized the "Features" section into categories (Visual Experience, Organization & Discovery, Collaboration & Sharing) for better scannability. - Added a "Screenshots" section with placeholders for visual examples. - Appended a new footer with a final call-to-action to try the demo and links to star the repo or report issues. - Ensured all existing content is preserved and integrated into the new structure. - Multiple mentions of the live demo URL are now present. The goal of these changes is to make the README more inviting, informative, and to drive users to the live demo.
feat: Enhance README.md for CodePatchwork
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…epatchwork Add winston logger
…codepatchwork Enable Winston logging for build
…esbuild-bundling Fix Winston logs after esbuild
…-directories Clean up unused db assets
…on-strings Remove connection string examples
…production Silence logs in production
…ge.json Add pg dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Remove duplicate close button in AboutModal