Skip to content

Conversation

@namurphy
Copy link

@namurphy namurphy commented Jun 5, 2025

If I remember correctly, pyhc-core only works on Python ≤ 3.11 since Kamodo currently doesn't work on Python ≥ 3.12. This PR makes installation of Kamodo contingent upon the version of Python being Python < 3.12.

Tasks

I'm making this a draft PR sort of as a placeholder, but hopefully I'll have a chance to come back to these tasks.

  • Update pyproject.toml
  • Test installation with Python 3.12 & 3.13
  • Double check that Kamodo still doesn't work on Python 3.12+
  • Add task to Kamodo import fails with Python 3.12 #9 to revert this PR when Kamodo supports Python 3.12+

@sapols
Copy link
Contributor

sapols commented Jun 11, 2025

Thanks again @namurphy, I appreciate it when you open issues.

I tried it again just now and pip install pyhc-core actually did pass with Python 3.12.11 (so did pip install pyhc-core[tests]).

I see Kamodo bumped their Python version to >=3.10 in September. Maybe that fixed it.

Although in doing that, I did find another problem on our horizon for Python 3.13: numpy<2 doesn't work in Python 3.13. So pip install pyhc-core fails in Python 3.13 because it fails to install numpy<2.

namurphy added 2 commits June 12, 2025 13:30
...since kamodo has an upper limit of `numpy < 2.0.0` and it sounds like Python 3.13 requires `numpy >= 2.0.0`
"pyspedas",
"spacepy",
"sunpy[all]",
"numpy<2.0.0" # most core packages don't yet support Numpy 2
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...since NumPy v2.0.0 was released approximately 0.988 years ago, by now core packages should have either become compatible with NumPy v2.0.0 or have numpy<2.0.0 as an explicit upper limit. I haven't confirmed this yet, though.

@namurphy
Copy link
Author

Thank you for following up!

Although in doing that, I did find another problem on our horizon for Python 3.13: numpy<2 doesn't work in Python 3.13. So pip install pyhc-core fails in Python 3.13 because it fails to install numpy<2.

Strange! I'm not sure what's happening here. I had a problem installing numpy==1.26.0 on CPython 3.13.0 because meson-build or something was missing, but I was able to get numpy==1.26.3 to install on CPython 3.13.0. 🤔

@namurphy
Copy link
Author

@sapols — please feel free to edit this PR directly since I was kind of doing this as a prototype, and haven't had time to confirm that things are working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants