-
Notifications
You must be signed in to change notification settings - Fork 25
Add type to container html repr #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1355 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 42 42
Lines 9742 9747 +5
Branches 1978 1979 +1
=======================================
+ Hits 9006 9011 +5
Misses 462 462
Partials 274 274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@h-mayorquin could you please resolve the conflicts? Why exclude top-level fields? I think it's useful, e.g., for the Units and Electrodes tables. The html repr is really about how the file is represented in memory in Python, as opposed to on-disk (for example, the "general" group is not shown). In almost all cases, the objects in the repr correspond to PyNWB/HDMF classes, and those match the neurodata type. In rare cases, they might deviate, e.g., when a class with a different name from the data type is mapped to the data type. Could we just use the class name instead of the data type name? |
I was looking at the trials and epochs that are also inside an intervals accessor at the top level and inferring wrongly that there all the top level things are just general containers (e.g. acquisition, processing, intervals, etc). But then, we have units and electrodes that are not like this so I guess let's just always display this. |
|
@rly I modified the code to match the suggestions. |
As discussed with @rly @stephprince and @rly
Take a look at the format.
Checklist
CHANGELOG.mdwith your changes?