Skip to content

Conversation

@mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Jul 7, 2025

Clean up HERDManager due to some updated logic downstream in pynwb
What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.62%. Comparing base (81760b8) to head (7024a24).
⚠️ Report is 30 commits behind head on dev.

Files with missing lines Patch % Lines
src/hdmf/container.py 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1292      +/-   ##
==========================================
- Coverage   91.63%   91.62%   -0.02%     
==========================================
  Files          42       42              
  Lines        9672     9684      +12     
  Branches     1962     1963       +1     
==========================================
+ Hits         8863     8873      +10     
- Misses        522      523       +1     
- Partials      287      288       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mavaylon1 mavaylon1 marked this pull request as ready for review July 11, 2025 18:48
@mavaylon1
Copy link
Contributor Author

Review Notes: This is for pynwb ticket NeurodataWithoutBorders/pynwb#2111

@rly rly merged commit 87c0df9 into dev Oct 3, 2025
27 of 28 checks passed
@rly rly deleted the herd_manager branch October 3, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants