Skip to content

Conversation

@tomhasura
Copy link
Contributor

@tomhasura tomhasura commented Mar 5, 2025

Description 📝

  • Use more detailed arch diagrams for Dedicated & BYOC
  • Under Dedicated, add section related to upgrade process and FAQs
  • Modify Basics section to include links to all sections in Private DDN
  • Rename DDN workspace to DDN Workspace

Quick Links 🚀

Assertion Tests 🤖

@tomhasura tomhasura requested a review from shahidhk March 5, 2025 21:59
@hasura-bot
Copy link
Contributor

@tomhasura Thanks for your PR! I've assigned @robertjdominguez to review it.

@hasura-bot
Copy link
Contributor

hasura-bot commented Mar 5, 2025

DX: Assertion Testing

✅ Diff

The updates to the image files in the documentation are a welcome addition to ensure visual congruence with the described architecture modifications, and the expansions to the FAQ sections provide more comprehensive answers to potential user questions, which can significantly improve the user's understanding. Updating the sidebar titles to maintain consistency is also a positive change.

✅ Integrated

The PR integrates well with the overall set of documentation, considering that it updates not only isolated sections but also ensures consistency across the board by changing file naming conventions, sidebars, and image paths to reflect an organized and coherent system. Documenting the upgrade process for the Dedicated Deployment is a critical piece for usability, and the added FAQ entries help users understand cloud provider availability and region support. The structural changes in the 'Private DDN' overview integrate seamlessly with the rest of the documentation.

@hasura-bot
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 25.9%, saving 345.22 KB.

Filename Before After Improvement Visual comparison
static/img/deployment/private_ddn_byoc_expanded.png 729.87 KB 558.73 KB -23.4% View diff
static/img/deployment/private_ddn_hasura_hosted_expanded.png 605.05 KB 430.97 KB -28.8% View diff

226 images did not require optimisation.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 5, 2025

Deploying ddn-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 634b06e
Status: ✅  Deploy successful!
Preview URL: https://54711577.v3-docs-eny.pages.dev
Branch Preview URL: https://tskawinski-private-ddn-arch.v3-docs-eny.pages.dev

View logs

Copy link
Collaborator

@robertjdominguez robertjdominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tomhasura!

@shahidhk will check over the arch diagrams.

tomhasura and others added 6 commits March 5, 2025 21:50
Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io>
Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io>
Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io>
Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants