-
Notifications
You must be signed in to change notification settings - Fork 34
New arch diagrams #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New arch diagrams #934
Conversation
|
@tomhasura Thanks for your PR! I've assigned @robertjdominguez to review it. |
DX: Assertion Testing✅ DiffThe updates to the image files in the documentation are a welcome addition to ensure visual congruence with the described architecture modifications, and the expansions to the FAQ sections provide more comprehensive answers to potential user questions, which can significantly improve the user's understanding. Updating the sidebar titles to maintain consistency is also a positive change. ✅ IntegratedThe PR integrates well with the overall set of documentation, considering that it updates not only isolated sections but also ensures consistency across the board by changing file naming conventions, sidebars, and image paths to reflect an organized and coherent system. Documenting the upgrade process for the Dedicated Deployment is a critical piece for usability, and the added FAQ entries help users understand cloud provider availability and region support. The structural changes in the 'Private DDN' overview integrate seamlessly with the rest of the documentation. |
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 25.9%, saving 345.22 KB.
226 images did not require optimisation. |
Deploying ddn-docs with
|
| Latest commit: |
634b06e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://54711577.v3-docs-eny.pages.dev |
| Branch Preview URL: | https://tskawinski-private-ddn-arch.v3-docs-eny.pages.dev |
robertjdominguez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tomhasura!
@shahidhk will check over the arch diagrams.
Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io>
Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io>
Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io>
Co-authored-by: Rob Dominguez <rob.dominguez@hasura.io>
Description 📝
DDN workspacetoDDN WorkspaceQuick Links 🚀
Assertion Tests 🤖