Skip to content

Use SFSafariViewController if available #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robbiet480 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use SFSafariViewController if available #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Classes/UI/HSArticleDetailViewController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
//OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
//THE SOFTWARE.
#import <UIKit/UIKit.h>
@import SafariServices;
#import "HSKBItem.h"
#import "HSViewController.h"

Expand Down
7 changes: 6 additions & 1 deletion Classes/UI/HSArticleDetailViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,12 @@ - (BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)

if(navigationType == UIWebViewNavigationTypeLinkClicked)
{
[[UIApplication sharedApplication] openURL:[request URL]];
if ([SFSafariViewController class] != nil) {
SFSafariViewController *safariVC = [[SFSafariViewController alloc]initWithURL:[request URL] entersReaderIfAvailable:NO];
[self presentViewController:safariVC animated:YES completion:nil];
} else {
[[UIApplication sharedApplication] openURL:[request URL]];
}
return false;
}
return true;
Expand Down