Skip to content

Respond with error for unhandled content encodings #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanongil wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Respond with error for unhandled content encodings #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8219495
Respond with error for unhandled content encodings
kanongil Aug 4, 2025
62e3c33
Add Accept-Encoding response header
kanongil Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,16 @@ internals.decoder = function (source, options) {

const contentEncoding = source.headers['content-encoding'];
const decoders = options.decoders ?? internals.decoders;
if (!decoders.hasOwnProperty(contentEncoding)) {
if (contentEncoding === undefined) {
return source;
}

if (!decoders.hasOwnProperty(contentEncoding)) {
const error = Boom.unsupportedMediaType();
error.output.headers = { 'accept-encoding': [...Reflect.ownKeys(decoders), 'identity'].join(', ') };
throw error;
}

const decoderOptions = options.compression?.[contentEncoding] ?? null;
const stream = decoders[contentEncoding](decoderOptions);

Expand Down
9 changes: 6 additions & 3 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ describe('parse()', () => {
expect(payload.toString()).to.equal(body);
});

it('leaves payload raw when encoding unknown', async () => {
it('errors when encoding unknown', async () => {

const body = '{"x":"1","y":"2","z":"3"}';
const compressed = await internals.compress('gzip', body);
Expand All @@ -632,8 +632,11 @@ describe('parse()', () => {
'content-type': 'application/json'
};

const { payload } = await Subtext.parse(request, null, { parse: 'gunzip', output: 'data' });
expect(payload.toString()).to.equal(compressed.toString());
const err = await expect(Subtext.parse(request, null, { parse: 'gunzip', output: 'data' })).to.reject('Unsupported Media Type');
expect(err.output.statusCode).to.equal(415);
expect(err.output.headers).to.include({
'accept-encoding': 'gzip, deflate, identity'
});
});

it('unzips payload without parsing (external decoders)', async () => {
Expand Down
Loading