Fix late write error on aborted streams #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marsup
reviewed
Aug 4, 2025
Contributor
Marsup
left a comment
Marsup
left a comment
There was a problem hiding this comment.
Ha, it's always windows... Not sure what's going on and I don't have a windows machine to test on.
test/index.js
Outdated
|
|
||
| const req = Http.request(options, (res) => { }); | ||
| req.on('error', Hoek.ignore); | ||
| req.on('error', Hoek.ignore); // For some reason the stream errors _after_ being destroyed... |
Contributor
There was a problem hiding this comment.
Isn't the fix supposed to avoid this situation?
Contributor
Author
There was a problem hiding this comment.
Yes, kinda. But this is a client error, that doesn't appear to be caused by incorrect API usage. I will make it more specific.
Contributor
Author
I made a fix in #104. |
Contributor
|
Looks like you were right! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.