Skip to content

Conversation

@MBoutray
Copy link
Contributor

@MBoutray MBoutray commented Apr 9, 2025

The trailing slashes on all base paths were removed to differentiate the base paths from the first page of each sidebar.

Screenshot of the update /guide/ page
creenshot of the update /guide/installation/ page

All pages now reference the correct pages in reference to themselves.
The current page is also highlighted in the sidebar.

fixes #161

Update sidebar configuration to ensure the first page's URL is not the same as the base path
This fixes the issue where navigating to the next page from the first would reopen the same page
@MBoutray MBoutray changed the title Fixes #161: Fix pagination of the first page of each sidebar Fix pagination of the first page of each sidebar Apr 9, 2025
@jaylinski
Copy link
Member

Thanks for the fix. Tested locally and works as expected.

Note that VitePress itself also uses relative sidebar-links, but it uses dedicated names for each page:
https://github.com/vuejs/vitepress/blob/70de34c0387d9668ada3ea9a795f9ebee3535f5b/docs/.vitepress/config/en.ts#L14-L17

@jaylinski jaylinski merged commit a26e680 into handlebars-lang:master Apr 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The pagination of the first page of each sidebar points to itself

2 participants