Peer Review comments #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall, I feel like your project is very thorough and complex and it looks like a really interesting concept for a game! I think most of my suggestions for the project would be concerned about organization, as certain classes especially within the game package could be better organized. The Game class is also very large and covers a significant amount of functionality, so it could most likely be split up into multiple different classes for rendering JavaFX and handling game logic. Many variables in different classes in your project could also be set to final since they are never changed after their initialization. You also mention that the fleet object within the Player class should be a LinkedList, but instead it is of type List, so it could be made into a LinkedList, which would make sorting and searching the player's fleet much easier.