Skip to content

[Partial] Fix for Issue #175: Implement RequireJS Error Handling #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
long-m-r wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Partial] Fix for Issue #175: Implement RequireJS Error Handling #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7546cd7
Update css.js
long-m-r Aug 30, 2015
c4c5b24
Update css.min.js
long-m-r Aug 30, 2015
ffc61fd
Update css.js
long-m-r Aug 30, 2015
62fdf58
Update css.min.js
long-m-r Aug 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,21 +146,23 @@ define(function() {
}
}, 10);
link.href = url;
// Support for requireJS error handling on links. Tested Chrome v44 & Firefox v40
link.onerror=function(error){
this.remove();
callback.error(error);
}
head.appendChild(link);
}

//>>excludeEnd('excludeRequireCss')
cssAPI.normalize = function(name, normalize) {
if (name.substr(name.length - 4, 4) == '.css')
name = name.substr(0, name.length - 4);

return normalize(name);
// Only append .css if it doesn't have it already or a ?
return normalize( /(\?|\.css$)/.test(name) ? name : name+'.css' );
}

//>>excludeStart('excludeRequireCss', pragmas.excludeRequireCss)
cssAPI.load = function(cssId, req, load, config) {

(useImportLoad ? importLoad : linkLoad)(req.toUrl(cssId + '.css'), load);
(useImportLoad ? importLoad : linkLoad)(req.toUrl(cssId), load);

}

Expand Down
2 changes: 1 addition & 1 deletion css.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.