Attendance book creation UX improvements #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch merges new_attendance() and attendance_settings() into one making the code more maintanable. As a byproduct, the following are addressed: * Removed checkrequired() from new_attendance() as it did nothing * Improved HTML structure by fixing incosistent div elements and removing a stray fieldset * Placeholders were introduced into the attendance book settings form * Title is now carried over on an invalid POST from the attendance book create form Co-authored-by: Tasos Sahanidis <tasos@tasossah.com>
Required attendances are now optional integers, greater or equal to 0. Co-authored-by: Tasos Sahanidis <tasos@tasossah.com>
Co-authored-by: Tasos Sahanidis <tasos@tasossah.com>
Co-authored-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
A function to aid in calculating the current and upcoming semesters has also been added. It provides information such as start/end dates and the academic year. Co-authored-by: Tasos Sahanidis <tasos@tasossah.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains improvements in regards to the user experience when it comes to attendance book creation.
More specifically:
These changes result in less friction when a professor creates a new attendance book.
In addition, some of the code has been cleaned up and a new
Semesterenum has been added.