Generate changes for new or deleted schemas #2923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-2923.graphql-inspector.pages.dev |
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-inspector/action |
5.0.16-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/cli |
6.0.4-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/audit-command |
5.0.16-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/coverage-command |
6.1.10-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/diff-command |
6.0.4-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/introspect-command |
5.0.16-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/similar-command |
5.0.16-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/validate-command |
5.0.16-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/core |
7.1.0-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
@graphql-inspector/patch |
0.1.0-alpha-20251210220709-671f8b3cdccca39e371f19a9a1cbf9a8ed76eac6 |
npm ↗︎ unpkg ↗︎ |
jdolle
commented
Nov 21, 2025
| Object.values(oldSchema.getTypeMap()).filter(t => !isPrimitive(t)), | ||
| Object.values(newSchema.getTypeMap()).filter(t => !isPrimitive(t)), | ||
| Object.values(oldSchema?.getTypeMap() ?? {}).filter( | ||
| t => !isPrimitive(t) && !isForIntrospection(t), |
Collaborator
Author
There was a problem hiding this comment.
Need to exclude these introspection types. Otherwise they'll show as "added" if null is passed as the oldSchema.
Before, both oldSchema and newSchema contained identical types and so no changes were output.
n1ru4l
reviewed
Nov 21, 2025
…wn' when these types are not defined
n1ru4l
reviewed
Dec 10, 2025
n1ru4l
approved these changes
Dec 10, 2025
Collaborator
n1ru4l
left a comment
n1ru4l
left a comment
There was a problem hiding this comment.
See https://github.com/graphql-hive/graphql-inspector/pull/2923/files#r2605625304
I am fine with doing a major release, it is just a number to me. 🤷
Some people might complain about doing this a minot, but I am also fine with taking that risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref CONSOLE-1540
Showing a list of changes can be useful even for new or deleted schemas.
This change allows
nullto be passed todiffas either the old and/or new schema.Currently, on Hive, checking a new schema shows "no changes". This isn't harmful since additions are safe, but it's confusing. Showing a full list of additions in the new schema would make much more sense.
Type of change
How Has This Been Tested?
See unit tests
Checklist:
CONTRIBUTING doc and the
style guidelines of this project