Skip to content

Conversation

@Blackqpid
Copy link

Added Canadian 1931 Census

@GaryGriffin
Copy link
Member

@Nick-Hall
I am not aware of anyone responsible for reviewing CA forms (some countries have a designated reviewer). I checked that it was consistent with CA1911 style, so see no issues with this PR. Are you okay with me publishing it or is there a specific CA reviewer?

@Nick-Hall
Copy link
Member

Gerald Britton contributed the initial Canadian census definitions, and I would usually ask him to review any changes or additions.

@GaryGriffin
Copy link
Member

To me, it looks like the CA forms were added when the Forms gramplet was initially created more than 10 years ago. Do you have contact info for Gerald? I see a possible match (python user from Toronto) with github user gbritton1 but no contact info.

<_attribute>Section</_attribute>
<size>3</size>
<_longname>4. Place of Abode: Section</_longname>
</column>
Copy link

@gbritton1 gbritton1 Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis section varies by province. e.g. in Ontario there are two options:
Rural: township and or parish
Urban: Street Number
And the numbering of the sections is different

but then in Alberta is is as coded here. Range, Meridian etc.

Not sure how to code this up in this xml

<column>
<_attribute>NoJob</_attribute>
<size>5</size>
<_longname>35. Weeks unemploted: No job</_longname>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling error. "unemploted" should be "unemployed" . sections 35-40

Copy link

@gbritton1 gbritton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to do this by province, since the sections differ e.g. between ON and AB and perhaps others (didn't check them all)

@GaryGriffin
Copy link
Member

As Gerald has pointed out, there are 4 different versions of this CA 1931 census form based on Province. He has provided an initial version of each for review:

Can you integrate these into the PR and test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants