Skip to content

Conversation

@greggman
Copy link
Contributor

In core it should always be undefined.
In compat it should be what was passed in or the default.

This passes in a build of chromium that exposes this property

In compatibility mode

Screenshot 2025-12-19 at 17 09 14

When not in compatibility mode

Screenshot 2025-12-19 at 17 09 07

Also checked Firefox stable (as chrome stable has trials on)

Screenshot 2025-12-19 at 17 26 15

In core it should always be undefined.
In compat it should be what was passed in or the default.
t.expect(texture.mipLevelCount === (descriptor.mipLevelCount || 1));
t.expect(texture.sampleCount === (descriptor.sampleCount || 1));
t.expect(
texture.textureBindingViewDimension ===
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside: We should also have a separate (idl) test for 'textureBindingViewDimension' in GPUTexture.prototype. It's a really minor interoperability thing, but I think we do want all browsers to implement it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we? At the moment the only thing a core implementation needs to do is add the 4 new limits. They do not need to add this textureBindingViewDimension and have it be undefined. It's undefined by the fact that it doesn't exist. I feel like that's fine. I also feel like apple would push back. From their POV it would be a wart and things would arguably work without adding it. (vs the limits which were required)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to mark this as resolved of that's ok. If we decide the getter is required then we can add an idl test at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants