-
Notifications
You must be signed in to change notification settings - Fork 89
Add a css-transitions player #3
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Ok @googlebot, I signed it... |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
You're welcome @googlebot ! |
|
Thanks very much! It's a great addition. I do have some nits, so I'll step through and add them if you're willing to tweak as needed? TBH some of them are to map to the .eslintrc rules. I should add the tests in as per #1 so they get caught automatically. |
No prob, go ahead !
Did my best to try to match the cs, but should be easier with an eslintrc |
|
This is the one I used, btw: {
"root": true,
"parser": "babel-eslint",
"env": {
"browser": true,
"es6": true
},
"extends": "eslint:recommended",
"rules": {
"indent": [2, 2],
"curly": [1, "multi-or-nest", "consistent"],
"quotes": [2, "single", "avoid-escape"],
"linebreak-style": [2, "unix"],
"semi": [2, "always"],
"no-multi-spaces": 2,
"space-before-function-paren": [2, "always"]
}
} |
|
I added the one I've been using to the repo, so we can standardize around that. I think we should add two of your rules: Do you fancy PR'ing that in, then checking this PR to see that it matches? Given #4 I guess some of the changes in this PR might be temporary, but as with that Issue I didn't want you to think I'd forgotten you ;) |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@googlebot w4t? |
|
@googlebot confirm! |
|
@googlebot sudo confirm ? |
|
@googlebot damnit! Something got weird with my rebase... |
# The first commit's message is: add a css-transitions player This commit also moves easing configuration to the different players. # This is the 2nd commit message: Modified eslintrc rules * Add eslint to devDependencies * Add eslint npm/gulp tasks * Modified eslintrc rules * eslinted source
27ee201 to
b89f737
Compare
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
@paullewis Ok, squashed everything together ... |
|
updates on this one? |
|
@ju1ius I just tried to use the Nothing seems to be standing out as the culprit in your changes, so I'm assuming that the dist file may not have built properly. If anyone's interested, here's a comparison I made of a dropdown animation using a The second animation (FLIP) seems to still have some frames dropping. Here's the culprit trace: I was hoping to test the CSS player and see if it was more performant :( |


Hi,
I've been using your flip technique since the blog post, and I was a bit surprised that you didn't include a css-only solution in this library... So here it is !
I also had to move the easing configuration responsibility to the different players, since css does not support functions, obviously.
Cheers.