feat: add requestID info in error exceptions

[rahul2393]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

[rahul2393]

/gemini review

[rahul2393]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a valuable feature for debugging by adding request ID information to exceptions. The implementation is comprehensive, using a new wrap_with_request_id utility and an _augment_errors_with_request_id context manager to consistently augment exceptions across numerous API call sites. The changes are well-tested, with updates to existing tests and new tests for the exception wrapping logic.

My review has identified a critical issue in how exception messages are modified, which could prevent the request ID from appearing in logs as intended. I have also pointed out a few areas where code duplication can be reduced to improve maintainability. Overall, this is a solid contribution that will improve the library's debuggability once the identified issues are addressed.

[gemini-code-assist]

The current implementation of modifying the error message by setting error.message is incorrect for GoogleAPICallError. It creates a new instance attribute that shadows the message property but does not change the underlying exception arguments. As a result, str(error) will not include the request_id, which would prevent it from appearing in logs.

To correctly update the exception message so that it's reflected when the exception is converted to a string, you should modify the error.args tuple.

Suggested change

	if hasattr(error, "message") and error.message:
	error.message = f"{error.message}, request_id = {request_id}"
	if error.message:
	new_message = f"{error.message}, request_id = {request_id}"
	error.args = (new_message,) + error.args[1:]

[rahul2393]

I tested both approaches:

from google.api_core.exceptions import Aborted

Approach 1: Setting error.message (current implementation)

error1 = Aborted('Transaction aborted')
error1.message = f'{error1.message}, request_id = 123'
print(str(error1)) # Output: "409 Transaction aborted, request_id = 123" ✓

Approach 2: Setting error.args only (suggested change)

error2 = Aborted('Transaction aborted')
new_message = f'{error2.message}, request_id = 456'
error2.args = (new_message,) + error2.args[1:]
print(str(error2)) # Output: "409 Transaction aborted" ✗ (request_id missing!)

GoogleAPICallError.str uses the message property rather than args, so modifying args alone doesn't update the string representation. The current implementation correctly updates error.message which is reflected in str(error).