Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.

Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620

sqlalchemy-spanner: 1.17.2

1.17.2 (2025-12-15)

Bug Fixes

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Dec 15, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated release generated by the Librarian CLI for sqlalchemy-spanner version 1.17.2. Its primary purpose is to publish a new version of the library that incorporates a crucial bug fix related to the ordering of columns in compound indexes. Merging this PR will trigger the automated release process, making the updated version available.

Highlights

  • New Release: This pull request initiates the release of sqlalchemy-spanner version 1.17.2.
  • Bug Fix: The new release includes a critical bug fix that ensures columns in compound indexes are retrieved in the correct order.
  • Automated Updates: Version numbers have been automatically updated across relevant files, including the CHANGELOG.md, .librarian/state.yaml, and google/cloud/sqlalchemy_spanner/version.py.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated release PR to bump the version of sqlalchemy-spanner to 1.17.2. The changes include updating the version in the configuration and source code, and adding a new entry to the CHANGELOG.md. The changes are mostly correct, but I've identified issues with the auto-generated links in the CHANGELOG.md file, which currently point to the wrong repository and are broken. My review comments include suggestions to fix these links.


[1]: https://pypi.org/project/sqlalchemy-spanner/#history

## [1.17.2](https://github.com/googleapis/google-cloud-python/compare/sqlalchemy-spanner-v1.17.1...sqlalchemy-spanner-v1.17.2) (2025-12-15)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repository URL and tag format in the version link appear to be incorrect, resulting in a broken link. Based on previous entries and the PR description, the repository should be python-spanner-sqlalchemy and the tags should not be prefixed.

Suggested change
## [1.17.2](https://github.com/googleapis/google-cloud-python/compare/sqlalchemy-spanner-v1.17.1...sqlalchemy-spanner-v1.17.2) (2025-12-15)
## [1.17.2](https://github.com/googleapis/python-spanner-sqlalchemy/compare/v1.17.1...v1.17.2) (2025-12-15)


### Bug Fixes

* Retrieve columns in compound indexes in correct order (#798) ([9afe49bb720356c58890931c17546650ffd61f88](https://github.com/googleapis/google-cloud-python/commit/9afe49bb720356c58890931c17546650ffd61f88))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repository URL in the commit link is incorrect, resulting in a broken link. It should point to the python-spanner-sqlalchemy repository. Additionally, for better readability, the link text for the commit should be the short hash, not the full one.

Suggested change
* Retrieve columns in compound indexes in correct order (#798) ([9afe49bb720356c58890931c17546650ffd61f88](https://github.com/googleapis/google-cloud-python/commit/9afe49bb720356c58890931c17546650ffd61f88))
* Retrieve columns in compound indexes in correct order (#798) ([9afe49bb](https://github.com/googleapis/python-spanner-sqlalchemy/commit/9afe49bb720356c58890931c17546650ffd61f88))

@Linchin Linchin self-requested a review December 15, 2025 22:58
@daniel-sanche daniel-sanche merged commit 0118eb3 into main Dec 15, 2025
73 of 78 checks passed
@daniel-sanche daniel-sanche deleted the librarian-20251215T133347Z branch December 15, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. release:done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants