Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Dec 12, 2025

This PR adds Python 3.14 as a supported version, and fixed tests for the new version

This PR also adds a dependency bound to pandas, as the upcoming 3.0.0 version is incompatible

@daniel-sanche daniel-sanche requested review from a team as code owners December 12, 2025 21:23
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 12, 2025
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. samples Issues that are directly related to samples. labels Dec 12, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates Python 3.14 as a fully supported version across the project. It involves comprehensive updates to the development environment, including continuous integration pipelines and project documentation, to reflect and accommodate the new Python release. Additionally, several unit tests were refined to ensure their continued accuracy and stability under Python 3.14, addressing potential changes in error reporting and module import mechanisms.

Highlights

  • Python 3.14 Support: Added official support for Python 3.14 by updating various configuration files, documentation, and CI/CD settings to include the new version.
  • CI/CD Configuration Updates: New Kokoro configurations were introduced for Python 3.14, covering common, continuous, periodic, and presubmit build types, ensuring automated testing for the new Python version.
  • Test Suite Enhancements: Modified existing unit tests to improve robustness and compatibility with Python 3.14, specifically by making error message assertions more flexible and refining the mocking of import functions.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/compliance.yml
    • .github/workflows/unittest.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively adds support for Python 3.14 by updating configuration files, dependencies, and tests. The changes are mostly correct, but I've identified a few areas for improvement. These include a potential copy-paste error in a build configuration file, inconsistencies in file formatting, a typo in a test function name, and a discrepancy in the supported Python versions listed across different files. Please review my specific comments for details.

env_vars: {
key: "INSTALL_LIBRARY_FROM_SOURCE"
value: "True"
} No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file is missing a newline at the end. For consistency with other configuration files in this repository, please add one. This will prevent potential issues with tools that expect a final newline.

env_vars: {
key: "INSTALL_LIBRARY_FROM_SOURCE"
value: "True"
} No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file is missing a newline at the end. For consistency with other configuration files in this repository, please add one. This will prevent potential issues with tools that expect a final newline.

vchudnov-g
vchudnov-g previously approved these changes Dec 12, 2025
@daniel-sanche daniel-sanche merged commit c164a47 into main Dec 12, 2025
25 checks passed
@daniel-sanche daniel-sanche deleted the 314 branch December 12, 2025 22:58
daniel-sanche added a commit that referenced this pull request Dec 15, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>db-dtypes: 1.5.0</summary>

##
[1.5.0](v1.4.3...v1.5.0)
(2025-12-15)

### Features

* Add support for Python 3.14 (#380)
([c164a47](c164a47b))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants