Skip to content

Conversation

@amanda-tarafa
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the sidekick/rust component by implementing robust detection for standard GET RPCs, as defined by AIP-131. The core purpose is to generate more idiomatic and user-friendly Rust client sample code for these specific operations. By identifying standard GETs, the system can now tailor the sample generation to directly accept a resource_name string, streamlining the developer experience and improving the clarity of generated examples.

Highlights

  • Standard GET RPC Detection: Introduced new Go logic to identify standard GET RPCs that conform to AIP-131 guidelines. This includes methods for checking if a method is a standard GET and extracting relevant information like the resource name field.
  • Rust Client Sample Generation: Updated the Rust client sample generation templates to leverage the new GET RPC detection. For standard GET methods, the generated sample code now uses a direct resource_name parameter instead of a full request object, leading to more idiomatic and concise examples.
  • Improved Sample Readability: The changes enhance the readability and usability of generated Rust client samples for standard GET operations by simplifying the parameter list and builder field usage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for generating samples for standard Get RPCs in Rust, following AIP-131. The changes include adding logic to the API model in Go to identify these standard methods, along with comprehensive tests. The Rust templates are updated to conditionally generate specialized sample code for these Get methods. The implementation looks solid. I have a couple of minor suggestions to improve code quality and maintainability.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.49%. Comparing base (cbd42a6) to head (fc95e99).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3312      +/-   ##
==========================================
+ Coverage   80.47%   80.49%   +0.02%     
==========================================
  Files         163      163              
  Lines       13869    13886      +17     
==========================================
+ Hits        11161    11178      +17     
  Misses       2126     2126              
  Partials      582      582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amanda-tarafa amanda-tarafa marked this pull request as ready for review December 19, 2025 00:46
@amanda-tarafa amanda-tarafa requested a review from a team as a code owner December 19, 2025 00:46
@amanda-tarafa
Copy link
Contributor Author

This is ready for review. Generation results can be seen in googleapis/google-cloud-rust#4095

Copy link
Contributor Author

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coryan I've replied to your comments but made no changes, yet, to see which you'd prefer on a couple of things.

Would it help if I add in this PR the code for the standard delete?

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help if I add in this PR the code for the standard delete?

Let's not complicate this PR. I like that it is very focused.

@amanda-tarafa
Copy link
Contributor Author

I've pushed the changes and updated googleapis/google-cloud-rust#4095. Thanks!

@amanda-tarafa amanda-tarafa merged commit 59cd235 into googleapis:main Dec 19, 2025
7 checks passed
@amanda-tarafa amanda-tarafa deleted the get-samples-parameters branch December 19, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants