-
Notifications
You must be signed in to change notification settings - Fork 36
feat(sidekick/rust): Generate samples for get RPCs #3312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sidekick/rust): Generate samples for get RPCs #3312
Conversation
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for generating samples for standard Get RPCs in Rust, following AIP-131. The changes include adding logic to the API model in Go to identify these standard methods, along with comprehensive tests. The Rust templates are updated to conditionally generate specialized sample code for these Get methods. The implementation looks solid. I have a couple of minor suggestions to improve code quality and maintainability.
internal/sidekick/rust/templates/common/client_method_samples/parameters.mustache
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
==========================================
+ Coverage 80.47% 80.49% +0.02%
==========================================
Files 163 163
Lines 13869 13886 +17
==========================================
+ Hits 11161 11178 +17
Misses 2126 2126
Partials 582 582 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3e12a42 to
301eaec
Compare
|
This is ready for review. Generation results can be seen in googleapis/google-cloud-rust#4095 |
internal/sidekick/rust/templates/common/client_method_samples/builder_fields.mustache
Outdated
Show resolved
Hide resolved
amanda-tarafa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coryan I've replied to your comments but made no changes, yet, to see which you'd prefer on a couple of things.
Would it help if I add in this PR the code for the standard delete?
internal/sidekick/rust/templates/common/client_method_samples/builder_fields.mustache
Outdated
Show resolved
Hide resolved
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it help if I add in this PR the code for the standard delete?
Let's not complicate this PR. I like that it is very focused.
internal/sidekick/rust/templates/common/client_method_samples/builder_fields.mustache
Outdated
Show resolved
Hide resolved
301eaec to
fc95e99
Compare
|
I've pushed the changes and updated googleapis/google-cloud-rust#4095. Thanks! |
No description provided.