Skip to content

Conversation

@ldetmer
Copy link

@ldetmer ldetmer commented Jan 2, 2026

We changed logic in librarian to pull the correct copyright year from the cargo.toml file header. For all libraries except for wkt this works correctly, but wkt seems to have a mismatch where cargo.toml's copyright year is 2024 but the generated files are all copyrighted 2025. This PR updates cargo.toml to match the generated files.

Alternatively the files could be updated to have 2024, if that is preferred.

Fixes googleapis/librarian#3405

@ldetmer ldetmer requested a review from a team as a code owner January 2, 2026 18:20
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.72%. Comparing base (1830c77) to head (1ee5a52).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4144   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         184      184           
  Lines        6933     6933           
=======================================
  Hits         6567     6567           
  Misses        366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc
Copy link
Member

dbolduc commented Jan 2, 2026

We changed logic in librarian to pull the correct copyright year from the Cargo.toml.

This sounds wrong. Why isn't copyright year an option in the sidekick configuration?

It also seems backwards when most Cargo.tomls are fully generated from the sidekick configuration...

wkt seems to have a mismatch where cargo.toml's copyright year is 2024 but the generated files are all copyrighted 2025

That's because src/wkt/Cargo.toml was added in 2024 and src/wkt/src/generated/... were added in 2025. The current values are correct.

@ldetmer
Copy link
Author

ldetmer commented Jan 2, 2026

thanks for the information, will close this and instead make fix in librarian logic

@ldetmer ldetmer closed this Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

librarian: running generate --all produces unexpected diffs for google-cloud-rust

2 participants