feat(storage): setting default checksum #30878
Open
+107
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhangi-google
requested review from
a team and
yoshi-approver
as code owners
shubhangi-google
changed the title
cpriti-os
requested changes
Oct 10, 2025
cpriti-os
requested changes
Nov 7, 2025
viacheslav-rostovtsev
previously approved these changes
Nov 10, 2025
cpriti-os
requested changes
Dec 30, 2025
| @@ -1805,6 +1805,7 @@ def create_file file, | |||
| path ||= file.path if file.respond_to? :path | |||
| path ||= file if file.is_a? String | |||
| raise ArgumentError, "must provide path" if path.nil? | |||
| checksum = :crc32c if checksum.nil? && crc32c.nil? && md5.nil? | |||
There was a problem hiding this comment.
We should document this clearly in an appropriate, that Crc32c will be used by default for integrity checks
| @@ -1091,6 +1111,10 @@ def empty_file_gapi cache_control: nil, content_disposition: nil, | |||
| content_encoding: nil, content_language: nil, | |||
| content_type: nil, crc32c: nil, md5: nil, metadata: nil, | |||
| storage_class: nil | |||
| # Set crc32c if both md5 and crc32c are not provided | |||
| if md5.nil? && crc32c.nil? | |||
There was a problem hiding this comment.
This section is repeated multiple times across test files, do we have a common test helper where it could be moved.
| @@ -610,7 +646,7 @@ | |||
|
|
|||
| it "creates an file with a StringIO" do | |||
| new_file_name = random_file_path | ||
| new_file_contents = StringIO.new "Hello world" | ||
| mock = Minitest::Mock.new | ||
| mock.expect :insert_object, create_file_gapi(bucket.name, new_file_name), |
There was a problem hiding this comment.
how are we verifying the checksum for the new String IO object here, also use a slightly different string in different tests for robustness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets Checksum CRC32C as default when we are uploading a file to bucket