Skip to content

Conversation

@hannesm
Copy link

@hannesm hannesm commented Jan 9, 2026

For #4581

Please note that I'm not an experienced Python programmer, happy to get feedback on this.

@google-cla
Copy link

google-cla bot commented Jan 9, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@AlexandreEXFO
Copy link

@hannesm : The list of data sources in the documentation could also be updated to add this new source. https://github.com/google/osv.dev/blob/master/docs/data.md

This updates this page: https://google.github.io/osv.dev/data/

@hannesm
Copy link
Author

hannesm commented Jan 9, 2026

@hannesm : The list of data sources in the documentation could also be updated to add this new source. https://github.com/google/osv.dev/blob/master/docs/data.md

This updates this page: https://google.github.io/osv.dev/data/

Thanks for your comment. FYI, this is not mentioned in the issue template for a new source (see #4581).

@hannesm
Copy link
Author

hannesm commented Jan 12, 2026

Anything I can do to move this forward? It looks like CI systems await approval (though I can't see the oss-vdb worker output).

@AlexandreEXFO
Copy link

@cuixq @another-rex

@another-rex
Copy link
Contributor

/gcbrun

@another-rex
Copy link
Contributor

/gcbrun

Copy link
Contributor

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can run most of the tests locally as well

make lib-tests
make lint

See Makefile for other tests available, but I think lib-tests is the one you need, though it will require you to have the poetry installed. (See CONTRIBUTING.md for full list of prerequisites. )

@another-rex
Copy link
Contributor

/gcbrun

@another-rex
Copy link
Contributor

/gcbrun

@another-rex
Copy link
Contributor

LGTM, though please fix the linting issues.

Use make lint to run the linter locally.

yapf -i <file> to format the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants