-
Notifications
You must be signed in to change notification settings - Fork 273
Add OPAM to osv.dev #4582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add OPAM to osv.dev #4582
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@hannesm : The list of data sources in the documentation could also be updated to add this new source. https://github.com/google/osv.dev/blob/master/docs/data.md This updates this page: https://google.github.io/osv.dev/data/ |
Thanks for your comment. FYI, this is not mentioned in the issue template for a new source (see #4581). |
|
Anything I can do to move this forward? It looks like CI systems await approval (though I can't see the oss-vdb worker output). |
|
/gcbrun |
|
/gcbrun |
another-rex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you can run most of the tests locally as well
make lib-tests
make lint
See Makefile for other tests available, but I think lib-tests is the one you need, though it will require you to have the poetry installed. (See CONTRIBUTING.md for full list of prerequisites. )
|
/gcbrun |
|
/gcbrun |
|
LGTM, though please fix the linting issues. Use
|
For #4581
Please note that I'm not an experienced Python programmer, happy to get feedback on this.