Add audio performance to AdpfWrapper #2330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwu1
changed the title
flamme
reviewed
Jan 9, 2026
| bool adpfEnabled, | ||
| bool adpfWorkloadIncreaseEnabled, | ||
| bool hearWorkload) { | ||
| int32_t targetDurationMs, |
Collaborator
There was a problem hiding this comment.
Why all indents are changed? should be 8 spaces instead of 4.
| std::shared_ptr<oboe::AudioStream> oboeStream = engine.getCurrentActivity()->getStream(streamIndex); | ||
| if (oboeStream != nullptr) { | ||
| oboe::PerformanceHintConfig cfg; | ||
| cfg.highPerformanceAudio = (highPerformance == JNI_TRUE); |
Collaborator
There was a problem hiding this comment.
Why it is needed to compare to JNI_TRUE?
| mNumVoicesSlider.getValue(), mAlternateNumVoicesSlider.getValue(), | ||
| mAlternatingPeriodMsSlider.getValue(), mEnableAdpfBox.isChecked(), | ||
| mEnableAdpfWorkloadIncreaseBox.isChecked(), mHearWorkloadBox.isChecked(), | ||
| mHighPerformanceAudioBox.isChecked(), reportActualDurationEnabled); |
Collaborator
There was a problem hiding this comment.
If adpf box is not checked, is reporting duration still needed?
| // If the platform does not support the high-performance-audio APERF feature, | ||
| // hide or disable the UI control so users don't attempt to enable it. | ||
| boolean hpSupported = NativeEngine.isHighPerformanceAudioSupported(); | ||
| if (!hpSupported && mHighPerformanceAudioBox != null) { |
Collaborator
There was a problem hiding this comment.
Q: when will mHighPerformanceAudioBox be null?
| android:layout_height="wrap_content" | ||
| android:layout_marginRight="8sp" | ||
| android:text="Hear Workload" /> | ||
|
|
Collaborator
There was a problem hiding this comment.
Maybe there are some common part of the UI can be extracted to a common class.
| --ez use_workload {true, false} // if true and using ADPF then report workload changes. Default is false. | ||
| --ez scroll_graphics {true, false} // if true then continually update the power scope. Default is false. | ||
| --ez use_workload_increase_api {true, false} // if true and using ADPF, notify adpf with workload increase/reset apis. Default is false. | ||
| --ez use_high_performance_audio {true, false} // if true, request highPerformanceAudio in the performance hint session creation config. Default is false. |
Collaborator
There was a problem hiding this comment.
Q: do you also want the option for reporting duration?
| --ez use_workload {true, false} // if true and using ADPF then report workload changes. Default is false. | ||
| --ez scroll_graphics {true, false} // if true then continually update the power scope. Default is false. | ||
| --ez use_workload_increase_api {true, false} // if true and using ADPF, notify adpf with workload increase/reset apis. Default is false. | ||
| --ez use_high_performance_audio {true, false} // if true, request highPerformanceAudio in the performance hint session creation config. Default is false. |
Collaborator
There was a problem hiding this comment.
Where is the implementation of use_high_performance_audio, I cannot find it from the code.
| } | ||
|
|
||
| void setReportActualDurationEnabled(bool enabled) override { | ||
| // Public API expects 'enabled'; internally we manage a 'disabled' flag. |
Collaborator
There was a problem hiding this comment.
What is the benefit of managing disable flag internally? This looks easily cause issue in the future because of inconsistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Oboe, apps can now see if the power HAL supports a special audio performance mode with ADPF and use it.