runsc: Add EROFS mount support in bundle config.json #12337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables EROFS filesystems to be specified as regular mounts in the OCI bundle config.json, not just as rootfs or debug mounts. EROFS mounts are now tracked in goferMountConfs alongside lisafs mounts. The implementation adds: - IsErofsMount() helper in specutils to identify EROFS mounts - Updated mount index tracking across container.go, gofer.go, and vfs.go - Support for opening EROFS image files and passing FDs to the sandbox - EROFS case in getMountNameAndOptions() for proper mount setup Key implementation details: - EROFS mounts are included in goferMountConfs but skip gofer-specific processing (e.g., lisafs serving, filestore creation) - Mount type determination happens before mount hint logic - Proper index tracking ensures EROFS mounts increment indices but skip lisafs-only operations Fixes google#12307
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables EROFS filesystems to be specified as regular mounts in the OCI bundle config.json, not just as rootfs or debug mounts.
EROFS mounts are now tracked in goferMountConfs alongside lisafs mounts. The implementation adds:
Key implementation details:
Fixes #12307