Skip to content

Conversation

@tomfeigin
Copy link
Contributor

@tomfeigin tomfeigin commented Dec 7, 2025

BREAKING CHANGE: UsageItem.Quantity is now type float64.

The organization usage report schema expected the 'Quantity' field to be a float.
This PR fixes the decoding of the usage report by conforming to the GitHub API schema

@gmlewis gmlewis changed the title fix: org usage report response decode fix!: Change Org usage report Quantity to float64 Dec 7, 2025
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Dec 7, 2025
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.36%. Comparing base (66f826c) to head (8cd9e34).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3862   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         199      199           
  Lines       14308    14308           
=======================================
  Hits        13215    13215           
  Misses        894      894           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tomfeigin!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 8, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 8, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis gmlewis merged commit 95c2a13 into google:master Dec 8, 2025
7 checks passed
elminster-aom added a commit to elminster-aom/go-github that referenced this pull request Dec 10, 2025
* forkstream/master:
  chore!: Remove `PullRequestRuleParameters.AutomaticCopilotCodeReviewEnabled` field (google#3866)
  feat: Add support for `copilot_code_review` rule type (google#3857)
  feat: Implement Enterprise SCIM - Delete Groups or Users (google#3856)
  feat: Add `advanced_search` parameter to `SearchOptions` (google#3868)
  fix!: Change Org usage report `Quantity` to `float64` (google#3862)
  build(deps): Bump actions/checkout from 6.0.0 to 6.0.1 in the actions group (google#3863)
  build(deps): Bump golang.org/x/sync from 0.18.0 to 0.19.0 in /tools (google#3864)
  build(deps): Bump golang.org/x/term from 0.37.0 to 0.38.0 in /example (google#3865)
  feat: Implement Enterprise SCIM - Set Groups or Users (google#3858)
  feat: Add support for Enterprise Team APIs (google#3861)
  Bump go-github from v79 to v80 in /scrape (google#3855)
  Bump version of go-github to v80.0.0 (google#3854)
  feat: Add repository target to ruleset (google#3850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants