-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add UploadReleaseAssetFromRelease convenience helper #3851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rockygeekz
wants to merge
4
commits into
google:master
Choose a base branch
from
rockygeekz:feat/upload-asset-from-release
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ed70edb
repos: add UploadReleaseAssetFromRelease convenience helper that uses…
rockygeekz 69a2c8b
repos: add UploadReleaseAssetFromRelease helper and tests; normalize …
rockygeekz a7a6dcb
repos: add UploadReleaseAssetFromRelease helper and tests; preserve a…
rockygeekz 501de8f
repos: finalize UploadReleaseAssetFromRelease helper and tests
rockygeekz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -488,3 +488,59 @@ func (s *RepositoriesService) UploadReleaseAsset(ctx context.Context, owner, rep | |
| } | ||
| return asset, resp, nil | ||
| } | ||
|
|
||
| // UploadReleaseAssetFromRelease uploads an asset using the UploadURL that's embedded | ||
| // in a RepositoryRelease object. | ||
| // | ||
| // This is a convenience wrapper that extracts the release.UploadURL (which is usually | ||
| // templated like "https://uploads.github.com/.../assets{?name,label}") and uploads | ||
| // the provided file using the existing upload helpers. | ||
| // | ||
| // GitHub API docs: https://docs.github.com/rest/releases/assets#upload-a-release-asset | ||
| // | ||
| //meta:operation POST /repos/{owner}/{repo}/releases/{release_id}/assets | ||
| func (s *RepositoriesService) UploadReleaseAssetFromRelease(ctx context.Context, release *RepositoryRelease, opts *UploadOptions, file *os.File) (*ReleaseAsset, *Response, error) { | ||
|
||
| if release == nil || release.UploadURL == nil { | ||
| return nil, nil, errors.New("release UploadURL must be provided") | ||
| } | ||
| if file == nil { | ||
| return nil, nil, errors.New("file must be provided") | ||
| } | ||
|
|
||
| // Extract upload URL and remove template part (e.g. "{?name,label}") if present. | ||
| uploadURL := *release.UploadURL | ||
| if idx := strings.Index(uploadURL, "{"); idx != -1 { | ||
| uploadURL = uploadURL[:idx] | ||
| } | ||
|
|
||
| // addOptions will append query params for name/label (same as UploadReleaseAsset) | ||
| u, err := addOptions(uploadURL, opts) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
|
|
||
| stat, err := file.Stat() | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| if stat.IsDir() { | ||
| return nil, nil, errors.New("the asset to upload can't be a directory") | ||
| } | ||
|
|
||
| mediaType := mime.TypeByExtension(filepath.Ext(file.Name())) | ||
| if opts != nil && opts.MediaType != "" { | ||
| mediaType = opts.MediaType | ||
| } | ||
|
|
||
| req, err := s.client.NewUploadRequest(u, file, stat.Size(), mediaType) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
|
|
||
| asset := new(ReleaseAsset) | ||
| resp, err := s.client.Do(ctx, req, asset) | ||
| if err != nil { | ||
| return nil, resp, err | ||
| } | ||
| return asset, resp, nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.