-
Notifications
You must be signed in to change notification settings - Fork 607
feat: Enable Rizzcharts sample and enhance client message handling #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doitundoit
wants to merge
1
commit into
google:main
Choose a base branch
from
doitundoit:refactor-rizzcharts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−5
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ import { Part, SendMessageSuccessResponse, Task } from "@a2a-js/sdk"; | |
| import { A2AClient } from "@a2a-js/sdk/client"; | ||
| import { v0_8 } from "@a2ui/lit"; | ||
|
|
||
| const A2AUI_MIME_TYPE = "application/json+a2aui"; | ||
| const A2AUI_MIME_TYPE = "application/json+a2ui"; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Huge thanks for the fix. Also, it would be great if we can decouple this fix into its own PR to limit the scope of the commit for posterity. |
||
|
|
||
| export class A2UIClient { | ||
| #serverUrl: string; | ||
|
|
@@ -97,13 +97,44 @@ export class A2UIClient { | |
| } | ||
|
|
||
| const result = (response as SendMessageSuccessResponse).result as Task; | ||
| if (result.kind === "task" && result.status.message?.parts) { | ||
| console.log("Full Server Response Result:", JSON.stringify(result, null, 2)); | ||
|
|
||
| let responseParts = result.status.message?.parts; | ||
|
|
||
| // Fallback: If no parts in status.message, check the last agent message in history | ||
| if (!responseParts && result.history && result.history.length > 0) { | ||
| // Iterate backwards to find the last agent message | ||
| for (let i = result.history.length - 1; i >= 0; i--) { | ||
| const msg = result.history[i]; | ||
| if (msg.role === 'agent' && msg.parts && msg.parts.length > 0) { | ||
| responseParts = msg.parts; | ||
| console.log("Found parts in history at index", i); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (result.kind === "task" && responseParts) { | ||
| const messages: v0_8.Types.ServerToClientMessage[] = []; | ||
| for (const part of result.status.message.parts) { | ||
| for (const part of responseParts) { | ||
| console.log("Client Received part:", JSON.stringify(part, null, 2)); | ||
|
|
||
| if (part.kind === 'data') { | ||
| messages.push(part.data as v0_8.Types.ServerToClientMessage); | ||
| let data = part.data; | ||
| if (typeof data === 'string') { | ||
| try { | ||
| data = JSON.parse(data); | ||
| console.log("Parsed string data:", data); | ||
| } catch (e) { | ||
| console.error("Failed to parse part.data string:", e); | ||
| } | ||
| } | ||
| messages.push(data as v0_8.Types.ServerToClientMessage); | ||
| } else if (part.kind === 'text') { | ||
| console.log("Ignored text part:", part.text); | ||
| } | ||
| } | ||
| console.log("Final messages to process:", messages); | ||
| return messages; | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of depending on an external service, can we serve the image directly from the client app from the public directory? This will reduce concerns for placehold.co availability.