Skip to content

runtime: delete unused parameter of userForced #76732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jianfengtony wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −5
Open

runtime: delete unused parameter of userForced #76732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/export_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,7 +1469,7 @@ func (c *GCController) Revise(d GCControllerReviseDelta) {

func (c *GCController) EndCycle(bytesMarked uint64, assistTime, elapsed int64, gomaxprocs int) {
c.assistTime.Store(assistTime)
c.endCycle(elapsed, gomaxprocs, false)
c.endCycle(elapsed, gomaxprocs)
c.resetLive(bytesMarked)
c.commit(false)
}
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/mgc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@ top:
// endCycle depends on all gcWork cache stats being flushed.
// The termination algorithm above ensured that up to
// allocations since the ragged barrier.
gcController.endCycle(now, int(gomaxprocs), work.userForced)
gcController.endCycle(now, int(gomaxprocs))

// Perform mark termination. This will restart the world.
gcMarkTermination(stw)
Expand Down
4 changes: 1 addition & 3 deletions src/runtime/mgcpacer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,9 +595,7 @@ func (c *gcControllerState) revise() {
}

// endCycle computes the consMark estimate for the next cycle.
// userForced indicates whether the current GC cycle was forced
// by the application.
func (c *gcControllerState) endCycle(now int64, procs int, userForced bool) {
func (c *gcControllerState) endCycle(now int64, procs int) {
// Record last heap goal for the scavenger.
// We'll be updating the heap goal soon.
gcController.lastHeapGoal = c.heapGoal()
Expand Down