Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Dec 5, 2025

  1. Add e-mail tooltip over non-existing username in commit view:
Screenshot 2025-12-05 at 09 43 08
  1. Replicate the same behaviour into commit list and latest commit:
Screenshot 2025-12-05 at 09 43 01

image

Now all three render the same tooltips. There is an existing e-mail tooltip over the avatar as well and this continues to work as-is.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 5, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 5, 2025
@lafriks
Copy link
Member

lafriks commented Dec 5, 2025

I don't think showing email in the UI is a good idea, maybe only for authorized users

@silverwind
Copy link
Member Author

It was already shown previously as a tooltip on the avatar in the commit view, but was not consistent.

@silverwind
Copy link
Member Author

And yes, I agree it should be hidden for anonymous users, but imho thats a separate topic and we need to validate all places where we pass these addresses to the frontend.

@silverwind
Copy link
Member Author

silverwind commented Dec 5, 2025

I think I could actually try to fix this at least in these 3 places, make a subtemplate for "avatar and username" and do the logged in check there, wip until then.

@silverwind silverwind marked this pull request as draft December 5, 2025 11:25
@silverwind silverwind changed the title Improve and unify non-existing user e-mail tooltip Improve and unify non-existing git commit user e-mail tooltip Dec 5, 2025
@lunny
Copy link
Member

lunny commented Dec 5, 2025

Since the repository is public, it can be accessed freely. Anyone can clone it and obtain the email information locally anyway.

@silverwind
Copy link
Member Author

I guess it has a small benefit against scrape bots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/templates This PR modifies the template files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants