-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Improve and unify non-existing git commit user e-mail tooltip #36094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I don't think showing email in the UI is a good idea, maybe only for authorized users |
|
It was already shown previously as a tooltip on the avatar in the commit view, but was not consistent. |
|
And yes, I agree it should be hidden for anonymous users, but imho thats a separate topic and we need to validate all places where we pass these addresses to the frontend. |
|
I think I could actually try to fix this at least in these 3 places, make a subtemplate for "avatar and username" and do the logged in check there, wip until then. |
|
Since the repository is public, it can be accessed freely. Anyone can clone it and obtain the email information locally anyway. |
|
I guess it has a small benefit against scrape bots. |
Now all three render the same tooltips. There is an existing e-mail tooltip over the avatar as well and this continues to work as-is.