Add first snapshot tests using insta #2813
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2411, with an important fix. The original PR was reverted in 6d62241 due to a regression in the stashes tab. When the app would open in the stashes tab, it would take a couple of seconds for the app to actually show content. The reason was that I had applied what looked like an optimization to me, but what actually apparently prevented an initial
QueueEvent::Notifyfrom being sent. This missing event caused the stashes view to only callself.draw(terminal)?on the nextQueueEvent::Tickwhich by default is after 5 seconds (if you changeTICK_INTERVALto a different value, you’ll see that it determines how long the app stays empty). This fix restores the code that was initially taken fromrun_appinmain.rs.As far as I can tell, this could also be fixed by adding an initial
self.draw(terminal)?call before theloopinrun_main_loop, right afterself.app.update()?.