Add create_discussion tool to discussions toolset #1519
+412
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements GraphQL mutation for creating discussions programmatically. Enables AI agents to create discussions in repositories and organizations. Closes github#1517
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new create_discussion tool to enable programmatic creation of GitHub Discussions through the MCP server. The implementation uses GraphQL mutations and follows existing patterns in the codebase for write operations.
Key changes:
- New
CreateDiscussionfunction using GraphQL mutation API - Registration of the tool in the discussions toolset as a write tool
- Comprehensive unit tests covering various scenarios
- Generated toolsnap for API schema validation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/discussions.go | Implements the CreateDiscussion function with GraphQL mutation, parameter validation, and error handling. Supports both repository-level and organization-level discussions (via .github repo). |
| pkg/github/tools.go | Registers CreateDiscussion as a write tool in the discussions toolset. |
| pkg/github/discussions_test.go | Adds comprehensive unit tests covering successful creation, organization-level discussions, missing parameters, and error scenarios (repository/category not found). |
| pkg/github/toolsnaps/create_discussion.snap | Tool schema snapshot for API validation (needs regeneration after fixing ReadOnlyHint issue). |
| README.md | Updates tool documentation with the new create_discussion tool and its parameters. |
| docs/remote-server.md | Changes "Default" to "all" in the toolset table (appears unrelated to this PR). |
| { | ||
| "annotations": { | ||
| "title": "Create discussion" | ||
| }, |
There was a problem hiding this comment.
The toolsnap is missing the readOnlyHint field that should be set to false for write operations. This needs to be regenerated after adding ReadOnlyHint: false to the tool annotations in discussions.go. Run UPDATE_TOOLSNAPS=true go test ./... to update the snapshot after fixing the code.
Suggested change
| }, | |
| }, | |
| "readOnlyHint": false, |
| | Name | Description | API URL | 1-Click Install (VS Code) | Read-only Link | 1-Click Read-only Install (VS Code) | | ||
| |----------------|--------------------------------------------------|-------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | Default | ["Default" toolset](../README.md#default-toolset) | https://api.githubcopilot.com/mcp/ | [Install](https://insiders.vscode.dev/redirect/mcp/install?name=github&config=%7B%22type%22%3A%20%22http%22%2C%22url%22%3A%20%22https%3A%2F%2Fapi.githubcopilot.com%2Fmcp%2F%22%7D) | [read-only](https://api.githubcopilot.com/mcp/readonly) | [Install read-only](https://insiders.vscode.dev/redirect/mcp/install?name=github&config=%7B%22type%22%3A%20%22http%22%2C%22url%22%3A%20%22https%3A%2F%2Fapi.githubcopilot.com%2Fmcp%2Freadonly%22%7D) | | ||
| | all | All available GitHub MCP tools | https://api.githubcopilot.com/mcp/ | [Install](https://insiders.vscode.dev/redirect/mcp/install?name=github&config=%7B%22type%22%3A%20%22http%22%2C%22url%22%3A%20%22https%3A%2F%2Fapi.githubcopilot.com%2Fmcp%2F%22%7D) | [read-only](https://api.githubcopilot.com/mcp/readonly) | [Install read-only](https://insiders.vscode.dev/redirect/mcp/install?name=github&config=%7B%22type%22%3A%20%22http%22%2C%22url%22%3A%20%22https%3A%2F%2Fapi.githubcopilot.com%2Fmcp%2Freadonly%22%7D) | |
There was a problem hiding this comment.
This change from "Default" to "all" appears to be unrelated to adding the create_discussion tool. If this is an intentional update to the remote server documentation, it should be in a separate commit or PR. Otherwise, this line should remain as "Default" to match line 91 which still references "Default toolset".
Suggested change
| | all | All available GitHub MCP tools | https://api.githubcopilot.com/mcp/ | [Install](https://insiders.vscode.dev/redirect/mcp/install?name=github&config=%7B%22type%22%3A%20%22http%22%2C%22url%22%3A%20%22https%3A%2F%2Fapi.githubcopilot.com%2Fmcp%2F%22%7D) | [read-only](https://api.githubcopilot.com/mcp/readonly) | [Install read-only](https://insiders.vscode.dev/redirect/mcp/install?name=github&config=%7B%22type%22%3A%20%22http%22%2C%22url%22%3A%20%22https%3A%2F%2Fapi.githubcopilot.com%2Fmcp%2Freadonly%22%7D) | | |
| | Default | All available GitHub MCP tools | https://api.githubcopilot.com/mcp/ | [Install](https://insiders.vscode.dev/redirect/mcp/install?name=github&config=%7B%22type%22%3A%20%22http%22%2C%22url%22%3A%20%22https%3A%2F%2Fapi.githubcopilot.com%2Fmcp%2F%22%7D) | [read-only](https://api.githubcopilot.com/mcp/readonly) | [Install read-only](https://insiders.vscode.dev/redirect/mcp/install?name=github&config=%7B%22type%22%3A%20%22http%22%2C%22url%22%3A%20%22https%3A%2F%2Fapi.githubcopilot.com%2Fmcp%2Freadonly%22%7D) | |
| Name: "create_discussion", | ||
| Description: t("TOOL_CREATE_DISCUSSION_DESCRIPTION", "Create a new discussion in a repository or organisation."), | ||
| Annotations: &mcp.ToolAnnotations{ | ||
| Title: t("TOOL_CREATE_DISCUSSION_USER_TITLE", "Create discussion"), |
There was a problem hiding this comment.
Missing ReadOnlyHint: false annotation. Write operations like create_discussion should explicitly set ReadOnlyHint: false to indicate they perform mutations. This is consistent with other write tools in the codebase (see create_gist, label_write, create_issue, etc.).
Suggested change
| Title: t("TOOL_CREATE_DISCUSSION_USER_TITLE", "Create discussion"), | |
| Title: t("TOOL_CREATE_DISCUSSION_USER_TITLE", "Create discussion"), | |
| ReadOnlyHint: mcp.BoolPtr(false), |
Comment on lines
+820
to
+831
| require.NoError(t, toolsnaps.Test(toolDef.Name, toolDef)) | ||
|
|
||
| assert.Equal(t, "create_discussion", toolDef.Name) | ||
| assert.NotEmpty(t, toolDef.Description) | ||
| schema, ok := toolDef.InputSchema.(*jsonschema.Schema) | ||
| require.True(t, ok, "InputSchema should be *jsonschema.Schema") | ||
| assert.Contains(t, schema.Properties, "owner") | ||
| assert.Contains(t, schema.Properties, "repo") | ||
| assert.Contains(t, schema.Properties, "categoryId") | ||
| assert.Contains(t, schema.Properties, "title") | ||
| assert.Contains(t, schema.Properties, "body") | ||
| assert.ElementsMatch(t, schema.Required, []string{"owner", "categoryId", "title", "body"}) |
There was a problem hiding this comment.
The test should verify that ReadOnlyHint is false for the write tool, similar to how other write tool tests do (e.g., create_gist, label_write). Add:
assert.False(t, toolDef.Annotations.ReadOnlyHint, "create_discussion tool should not be read-only")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1517
This PR adds a new
create_discussiontool to the discussions toolset, enabling programmatic creation of GitHub Discussions through the MCP server.Changes
CreateDiscussionfunction inpkg/github/discussions.gousing GraphQL mutationTesting
script/generate-docsThe tool follows existing patterns in the codebase and integrates cleanly with the current discussions toolset structure.