Pause Follow and Unfollow endpoints #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This pull request introduces new functionality to pause the follow process for CCR as well as updates the existing unfollow endpoint in the ElastomerClient. Key changes include:
- Adding a new pause_follow method with documentation and a corresponding API call
- Updating the unfollow method documentation to clarify usage and pre-conditions
- Enhancing test coverage by adding helper methods and tests for follow, pause_follow, and unfollow endpoints
- Switching test hook syntax from the default to before/after :each blocks for consistency
Changes
| File | Description |
|---|---|
| lib/elastomer_client/client/ccr.rb | Added pause_follow endpoint; updated unfollow docs |
| test/client/ccr_test.rb | Added tests for pause_follow and unfollow endpoints |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
lib/elastomer_client/client/ccr.rb:42
- [nitpick] The comment for 'follower_index' could be reworded to clarify the intent, e.g., 'follower_index - String name of the follower index to pause'.
# follower_index - String name of the follower index pause
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
sarwaan001
changed the title
jherns
reviewed
Feb 13, 2025
Contributor
jherns
left a comment
jherns
left a comment
There was a problem hiding this comment.
This looks really good. I left a few comments and suggestions. I really liked the helper functions you added to the tests
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: John Hernley <jherns@github.com>
Co-authored-by: John Hernley <jherns@github.com>
Co-authored-by: John Hernley <jherns@github.com>
Co-authored-by: John Hernley <jherns@github.com>
dtaivpp
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.