Skip to content

Conversation

@thorrsson
Copy link
Contributor

removes 2 redundant inclusions of params in a params.merge() call in reindex.rb

** There are 2 failing tests that also fail on the main branch, unrelated to this change

  1) Failure:
ElastomerClient::Client::Snapshot#test_0005_gets snapshot status for one and all [test/client/snapshot_test.rb:73]:
Expected: 1
  Actual: 2

  2) Failure:
ElastomerClient::Client::Snapshot#test_0003_creates snapshots with options [test/client/snapshot_test.rb:51]:
--- expected
+++ actual
@@ -1 +1 @@
-["elastomer-snapshot-test-index"]
+[".tasks", "elastomer-snapshot-test-index"]

removes 2 redundant inclusions of params in a params.merge() call in reindex.rb
Copilot AI review requested due to automatic review settings February 10, 2025 18:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request removes redundant inclusions of the params variable in the params.merge() calls within the reindex and rethrottle methods. The changes clean up unnecessary duplication in the method calls while keeping the original functionality intact.

  • Removed duplicate params in reindex method's merge call.
  • Removed duplicate params in rethrottle method's merge call.

Changes

File Description
lib/elastomer_client/client/reindex.rb Removed redundant inclusion of params in merge calls for clarity.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@thorrsson thorrsson merged commit 678bf5b into main Feb 10, 2025
5 checks passed
@thorrsson thorrsson deleted the fix-params-merges branch February 10, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants