Skip to content

0 script diffs are logged as debug instead of info #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdseaton merged 2 commits into from
Dec 16, 2025
+13 −2
Merged

0 script diffs are logged as debug instead of info #128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14b036b
0 script diffs are logged as debug instead of info
sdseaton Dec 11, 2025
8a925dc
Update KustoSchemaTools/Changes/DatabaseChanges.cs
sdseaton Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions KustoSchemaTools/Changes/DatabaseChanges.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,13 +194,13 @@ private static List<IChange> GenerateScriptCompareChanges<T>(Database oldState,
if (existing.ContainsKey(item.Key))
{
var change = new ScriptCompareChange(item.Key, existing[item.Key], item.Value);
log.LogInformation($"{item.Key} already exists, created {change.Scripts.Count} script to apply the diffs");
LogChangeResult(log, item.Key, change.Scripts.Count, alreadyExists: true);
tmp.Add(change);
}
else
{
var change = new ScriptCompareChange(item.Key, null, item.Value);
log.LogInformation($"{item.Key} doesn't exist, created {change.Scripts.Count} scripts to create it.");
LogChangeResult(log, item.Key, change.Scripts.Count, alreadyExists: false);
tmp.Add(change);
}
}
Expand Down Expand Up @@ -340,6 +340,17 @@ private static List<IChange> GenerateFollowerCachingChanges(FollowerDatabase old

return result;
}

private static void LogChangeResult(ILogger log, string entityKey, int scriptCount, bool alreadyExists)
{
var level = scriptCount > 0 ? LogLevel.Information : LogLevel.Debug;
var scriptsLabel = scriptCount == 1 ? "script" : "scripts";
var message = alreadyExists
? $"{entityKey} already exists, created {scriptCount} {scriptsLabel} to apply the diffs."
: $"{entityKey} doesn't exist, created {scriptCount} {scriptsLabel} to create it.";

log.Log(level, message);
}
}

}
Loading