console: allow using arrow left/right, home/end keys and history mode #17836
+344
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Thanks @ServeurpersoCom for testing & adding some improvements on windows! CC @ggerganov , this is a small feature but quite important for the UX - hope to get it merged soon! |
ngxson
force-pushed
the
xsn/cli_arrow_left_right
branch
from
cd05610 to
77ca259
Compare
Xsn/cli arrow left right
ngxson
changed the title
Collaborator
Author
|
FYI, I merged some more changes from @ServeurpersoCom to include history too (using up/down keys) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17828
Fix #17829
To test it, run
llama-cli, write some text (without sending it) and use left/right arrows to edit themEdit: Home/end keys and history support is allso added thanks to @ServeurpersoCom
Disclosure AI usage:
next_utf8_char_posis written by AI because I have no experience working with windows API. The rest is mostly written by me (minus some small auto-completion)