Skip to content

fix(tracemetrics): Improve metrics analytics #104495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-fish merged 5 commits into from
Dec 8, 2025
+395 −130
Merged

fix(tracemetrics): Improve metrics analytics #104495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4fa040
fix(tracemetrics): Improve metrics analytics
k-fish Dec 4, 2025
9a1e007
knip
k-fish Dec 8, 2025
64ab971
Add test for filter analytics in metrics explorer
k-fish Dec 8, 2025
c19e6f8
Use toHaveBeenCalledWith instead of find for analytics test
k-fish Dec 8, 2025
6bfaefb
Filter to get correct counts
k-fish Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions static/app/utils/analytics/metricsAnalyticsEvent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,21 @@ export type MetricsAnalyticsEventParameters = {
metric_panels_with_group_bys_count: number;
metric_queries_count: number;
project_count: number;
title: string;
};
'metrics.explorer.panel.metadata': {
columns: readonly string[];
columns_count: number;
aggregate_function: string;
confidences: string[];
dataScanned: string;
dataset: string;
empty_buckets_percentage: number[];
group_bys: readonly string[];
interval: string;
metric_name: string;
metric_type: string;
query_status: 'success' | 'error' | 'pending';
sample_counts: number[];
table_result_length: number;
table_result_missing_root: number;
table_result_mode: 'metric samples' | 'aggregates';
table_result_sort: string[];
user_queries: string;
Expand Down
Loading
Loading