Skip to content

chore(aci): Old flag clean-up #104484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kcons wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(aci): Old flag clean-up #104484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/sentry/options/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3315,12 +3315,6 @@
flags=FLAG_AUTOMATOR_MODIFIABLE,
)

register(
"workflow_engine.use_cohort_selection",
type=Bool,
default=True,
flags=FLAG_AUTOMATOR_MODIFIABLE,
)
register(
"workflow_engine.schedule.min_cohort_scheduling_age_seconds",
type=Int,
Expand Down
5 changes: 1 addition & 4 deletions tests/sentry/workflow_engine/processors/test_schedule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@ class ProcessBufferedWorkflowsTest(CreateEventTestCase):
{"delayed_workflow.rollout": True},
)
@patch("sentry.workflow_engine.processors.schedule.process_in_batches")
def test_fetches_from_buffer_and_executes_with_conditional_delete(
self, mock_process_in_batches: MagicMock
) -> None:
def test_fetches_from_buffer_and_executes(self, mock_process_in_batches: MagicMock) -> None:
project = self.create_project()
project_two = self.create_project()
group = self.create_group(project)
Expand Down Expand Up @@ -521,7 +519,6 @@ def test_chosen_projects_exception_during_processing(self, mock_project_chooser:
mock_buffer_client.persist_updates.assert_not_called()


@override_options({"workflow_engine.scheduler.use_conditional_delete": True})
def test_mark_projects_processed_only_cleans_up_processed_projects() -> None:
"""Test that mark_projects_processed only cleans up processed projects, not all projects."""
processed_project_id = 5000
Expand Down
Loading