openapi3: Serialize Extensions when using $ref #1005
+128
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I read through more of the package, and in the process of reworking this to be consistent and work more correctly. |
Author
|
@fenollp Would you be open to taking a look at this PR? |
Collaborator
|
Hi @irees Sorry for the delay. |
Author
|
@fenollp Thank you for your response. I've rebased. Let me know if anything else is needed. I am currently using my fork as part of the doc tools for my project, so it is actively used and tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was pleased to see the recent merging of #901, and this is a minor follow-on to that PR.
901 added support for reading
x-extensions when using$ref. This extends this by round-trippingx-extensions back out to JSON / YAML.I followed 901 to see what changes to make, since much of the code is auto-generated. I will open this as a Draft PR; if maintainers are OK with the basic idea, I will finish adding tests for the round-trip behavior and ask for formal review.