Skip to content

Conversation

@google-labs-jules
Copy link

This PR fixes the smoke test failures on Java 21 by using a compatible version of the spring-petclinic test fixture and ensuring the annotation project is built before the tests are run.


PR created automatically by Jules for task 13466429113652473982 started by @dividedmind

…h the version of the `spring-petclinic` test fixture being used.

This commit addresses the issue by:
- Modifying the `agent/bin/test_projects` script to use a specific, known-good commit of `spring-petclinic` for Java 21 test runs. This is the same commit that is used for Java 17.
- Updating the `agent/bin/test_install` script to build the `annotation` project before the test fixtures, ensuring that the necessary annotation JAR is available to the Maven build.
- Removing a redundant `source` command from `agent/bin/test_install`.

With these changes, the project now builds and runs tests successfully on Java 21.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant