feat: add light global theme, remove assets from repo #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new light global theme and refactors the repository to use a git submodule for branding assets. The changes are mostly correct, but I found a typo in the new light theme's configuration that will prevent the splash screen from loading correctly. My review includes a suggestion to fix this.
...es/shared/usr/share/plasma/look-and-feel/dev.getaurora.auroralight.desktop/contents/defaults
Outdated
Show resolved
Hide resolved
renner0e
force-pushed
the
light-theme
branch
3 times, most recently
from
4259952 to
24eda8a
Compare
Collaborator
Author
|
this is fine and doesn't blow anything up |
renner0e
requested review from
NiHaiden,
hanthor,
inffy and
ledif
as code owners
This doesn't change any defaults, it will still be dark and more intended for completion as there was just this light counterpart missing.
adds the Plasma made by KDE in the bottom right corner
NiHaiden
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change any defaults, it will still be dark and more
intended for completion as there was just this light counterpart
missing.