RuntimeError: dictionary changed size during iteration #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initialize_krb5_error_table is unnecessary with OS X's version of com_err. And besides that, it's an undefined symbol
As the class is currently defined, there are potential threading issues that might arise if different credentials are passed to the client in different threads, as it is currently a singleton.
activedirectory.protocol.asn1 was operating with str in python 3; this was resulting in a different value being passed to the socket when six.ensure_text was called; all of these protocol modules now use bytes. Also added the ability for a custom dns.resolver.Resolver instance to be set on the activedirectory.core.locate.Locator singleton, so that custom nameservers can be used to resolve the SRV netlogon queries. fixes FUN-2111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
sorry no time to create a real PR but see this :
https://github.com/theatlantic/python-active-directory/blob/a1e2a78a25ea60cbcaf2fc2ec4d5e8743e03ec64/lib/activedirectory/core/client.py#L315
It should be
for key in list(attrs):instead of
for key in attrs.keys():to avoid the RuntimeError error (it happens with keys like
member;range=0-1499that needs to be full retrieved)