feat(pallet-gear): Add compatibility check for code instrumentation #4864
+241
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukint-vs
added
A0-pleasereview
|
Review changes with Changed Files
|
breathx
reviewed
Sep 26, 2025
Member
breathx
left a comment
breathx
left a comment
There was a problem hiding this comment.
Except questions from above, looks good
ark0f
requested changes
Sep 27, 2025
ukint-vs
force-pushed
the
vs/reinstrument-check-try-state
branch
from
5cc3eb8 to
28192d0
Compare
breathx
changed the title
breathx
reviewed
Sep 29, 2025
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
breathx
approved these changes
Oct 27, 2025
ark0f
requested changes
Oct 27, 2025
ukint-vs
added
A2-mergeoncegreen
ark0f
requested changes
Nov 17, 2025
.github/workflows/build.yml
Outdated
| curl -sL https://github.com/paritytech/try-runtime-cli/releases/download/v0.8.0/try-runtime-x86_64-unknown-linux-musl -o try-runtime | ||
| chmod +x ./try-runtime | ||
| - name: "System: Report disk headroom (before cleanup)" |
Member
There was a problem hiding this comment.
All of these steps can be removed after master branch merged
ark0f
reviewed
Nov 26, 2025
| needs: [dynamic-matrix, node] | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| SNAPSHOT_FILE: vara_ci.snap |
Comment on lines
+432
to
+433
| find target -mindepth 1 -maxdepth 1 -print -exec ionice -c3 nice -n 19 rm -rf {} + | ||
| sync |
| --no-weight-warnings \ | ||
| snap -p "$SNAPSHOT_FILE" | ||
| - name: "System: Disable swap" |
Member
There was a problem hiding this comment.
No need to disable it on GitHub runners
Comment on lines
+447
to
+450
| EXTRA_ARGS=() | ||
| if [ "$DISABLE_SPEC_NAME_CHECK" = "true" ]; then | ||
| EXTRA_ARGS+=(--disable-spec-name-check) | ||
| fi |
Member
There was a problem hiding this comment.
This is why I suggested args: --disable-spec-name-check --etc - to simplify step. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a
try_statefunction that verifies all stored program codes can be successfully instrumented with the current schedule before runtime upgrades.OriginalCodeStorageSuccessor to #4598
@gear-tech/dev