-
Notifications
You must be signed in to change notification settings - Fork 113
refactor(gtest): improve API and docs #4850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
techraed
wants to merge
24
commits into
master
Choose a base branch
from
st-gtest-refine-interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A1-inprogress
Issue is in progress or PR draft is not ready to be reviewed
A5-dontmerge
PR should not be merged yet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActorMailboxtoUserMailbox, because there's no mailbox for programsLogs (LogandCoreLog,DecodedCoreLog) were introduced in the beginning of thegtest. Being useful, however, the naming was wrong. Also several types and API being 1) dependent onInto<Log>, 2) usingLogto compare it toCoreLog, which itself is derived from user stored message, 3) having vague builder impl forLog, 4) having no utility for users ofCoreLogmade the API ambiguous. Now the concept is straightforward and clean. You have justUserMessageEventderived fromStoredMessages stored as events (not in mailbox) andEventBuilderto build those events and perform ops with them inBlockRunResultorUserMailbox