all update docs #104
Merged
all update docs #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Connect Python codebase to replace
ConnectOptionswithHandlerOptionsacross multiple files and updates documentation for improved clarity and consistency. The changes ensure better alignment with the updated API while simplifying the codebase and enhancing readability.Replacement of
ConnectOptionswithHandlerOptions:cmd/protoc-gen-connect-python/generator/generator.go: ReplacedConnectOptionswithHandlerOptionsin function definitions and method calls for handler creation. [1] [2] [3]conformance/gen/connectrpc/conformance/v1/conformancev1connect/service_connect.py: Updated handler creation and method options to useHandlerOptionsinstead ofConnectOptions. [1] [2]examples/proto/connectrpc/eliza/v1/v1connect/eliza_connect.py: Refactored handler creation and imports to useHandlerOptions. [1] [2]src/connect/__init__.py: ReplacedConnectOptionswithHandlerOptionsin the module exports and imports. [1] [2]Documentation Improvements:
src/connect/call_options.py: Enhanced class-level docstrings forCallOptionsto provide clearer descriptions of attributes and functionality.src/connect/client.py: Updated docstrings forClientConfigand related methods to improve clarity and align with the updated API. [1] [2] [3] [4] [5]These changes streamline the codebase and improve its maintainability while ensuring consistency with the latest API updates.