Skip to content

Conversation

@bgruening
Copy link
Member

And in turn, I think we have stolen this from ORG.

ping @natefoo

@cat-bro
Copy link
Collaborator

cat-bro commented Dec 22, 2025

I don’t think this would be useful on AU because users tend not to be making use of the advanced_options, and it looks like the memory setting in this rule is entirely depends on these. We’re finding input_size to be a reasonable ballpark indicator of memory use, though we tend to overallocate to avoid OOM errors. .org has a scaling rule that looks nice: https://github.com/galaxyproject/usegalaxy-playbook/blob/main/env/common/templates/galaxy/config/tpv/tools.yaml.j2#L481

@bgruening
Copy link
Member Author

What that mean is that the usual cores * 3.8 is enough for most of the runs. The rule is specific for VGP. Experts can set this hg_size param - or in case of VGP it is automatically calculated inside a workflow, to adjust memory usage. hg_size is the "Estimated haploid genome size" and is strongly correlated with memory usage.

I will add a comment.

toolshed.g2.bx.psu.edu/repos/bgruening/hifiasm/hifiasm/.*:
cores: 20
mem: 120
cores: 10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cores: 10
cores: 20
mem: 120
- id: hifiasm_small_input_rule
if: 0.07 <= input_size < 9.4
cores: 8
mem: 28
- id: hifiasm_scalable_input_rule
if: input_size >= 9.4
cores: 16
mem: min(max(int(input_size * 5), 28), max_scaled_mem)

If you like that more, you can take that one in addition, I think. If hg_size is set, it should be more accurate and should be taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants