-
Notifications
You must be signed in to change notification settings - Fork 16
hifiasm rule from EU #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
hifiasm rule from EU #101
Conversation
|
I don’t think this would be useful on AU because users tend not to be making use of the advanced_options, and it looks like the memory setting in this rule is entirely depends on these. We’re finding input_size to be a reasonable ballpark indicator of memory use, though we tend to overallocate to avoid OOM errors. .org has a scaling rule that looks nice: https://github.com/galaxyproject/usegalaxy-playbook/blob/main/env/common/templates/galaxy/config/tpv/tools.yaml.j2#L481 |
|
What that mean is that the usual I will add a comment. |
| toolshed.g2.bx.psu.edu/repos/bgruening/hifiasm/hifiasm/.*: | ||
| cores: 20 | ||
| mem: 120 | ||
| cores: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| cores: 10 | |
| cores: 20 | |
| mem: 120 | |
| - id: hifiasm_small_input_rule | |
| if: 0.07 <= input_size < 9.4 | |
| cores: 8 | |
| mem: 28 | |
| - id: hifiasm_scalable_input_rule | |
| if: input_size >= 9.4 | |
| cores: 16 | |
| mem: min(max(int(input_size * 5), 28), max_scaled_mem) |
If you like that more, you can take that one in addition, I think. If hg_size is set, it should be more accurate and should be taken.
And in turn, I think we have stolen this from ORG.
ping @natefoo